Add commit signing detection to setup skill#144
Merged
Conversation
Member
Author
Review SummaryVerdict: APPROVE Findings
|
Member
Author
Review SummaryVerdict: APPROVE Findings
No blocking issues found. The new Phase 2 (commit signing) is well-structured: it checks existing config before prompting, has confirmation gates on every write, handles both the "key exists" and "no key found" branches with appropriate user interaction, and provides an escape hatch to external docs. Phase renumbering (2-4 becomes 3-5) is applied consistently across all six adapter files, including cross-references in the label population note ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new Phase 2 (commit signing) to the setup skill. When a project requires signed commits,
/setupnow detects existing signing configuration, asks the user if signing is needed, verifies a signing key exists, and enablescommit.gpgsignandtag.gpgsignat the repo level. This avoids token-wasting recovery loops when agents create unsigned commits that get rejected by branch protection.The change is purely at the git config layer — no new config placeholders or skill template conditionals needed. All skills that create commits or tags benefit automatically.
Issue #143